mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 48907: Enabled allocator transfer the fairnessExcludeResourceNames to sorter.
Date Fri, 01 Jul 2016 00:45:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48907/#review140274
-----------------------------------------------------------


Ship it!





src/master/allocator/mesos/hierarchical.cpp (lines 147 - 151)
<https://reviews.apache.org/r/48907/#comment205640>

    Ideally we could just update the factory function to call the initialize for us always.
For now, let's just do the following:
    
    ```
      roleSorter.reset(roleSorterFactory());
      roleSorter->initialize(fairnessExcludeResourceNames);
      quotaRoleSorter.reset(quotaRoleSorterFactory());
      quotaRoleSorter->initialize(fairnessExcludeResourceNames);
    ```



src/master/allocator/mesos/hierarchical.cpp (lines 237 - 242)
<https://reviews.apache.org/r/48907/#comment205642>

    No need for the comment since we're always supposed to initialize the sorter:
    
    ```
        frameworkSorters[role].reset(frameworkSorterFactory());
        frameworkSorters[role]->initialize(fairnessExcludeResourceNames);
    ```


- Benjamin Mahler


On June 30, 2016, 7:59 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48907/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 7:59 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5622
>     https://issues.apache.org/jira/browse/MESOS-5622
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled allocator transfer the fairnessExcludeResourceNames to sorter.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp c3639342335499a04a23147a4205f1b475c123fa

> 
> Diff: https://reviews.apache.org/r/48907/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message