mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 49465: Implemented GET_EXECUTORS Call in v1 master API.
Date Fri, 01 Jul 2016 00:13:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49465/#review140281
-----------------------------------------------------------




src/master/http.cpp (line 1524)
<https://reviews.apache.org/r/49465/#comment205651>

    I think we should also include orphan executors that are in `Slave.executors` map but
not in `frameworks`?



src/tests/api_tests.cpp (line 337)
<https://reviews.apache.org/r/49465/#comment205653>

    I think you can kill this comment. It is not giving that much information.


- Vinod Kone


On June 30, 2016, 7:04 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49465/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 7:04 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay Guo, Shuai
Lin, Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-5750
>     https://issues.apache.org/jira/browse/MESOS-5750
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented GET_EXECUTORS Call in v1 master API.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp e5acdb8e0bbcd7a2b7e8a8bc7f4bbeaae2c4fea1 
>   src/master/master.hpp e2ab2110fe5a287ab16ac9ef4222fed633e02ebe 
>   src/master/validation.cpp 6939d0e6ac3dbddc10f0315bd0a696a1f71634e2 
>   src/tests/api_tests.cpp b3127b716480223a6f23b7908bf6bc1808120f80 
> 
> Diff: https://reviews.apache.org/r/49465/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message