From reviews-return-37327-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sun Jun 19 04:21:33 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AB89C191DF for ; Sun, 19 Jun 2016 04:21:33 +0000 (UTC) Received: (qmail 20476 invoked by uid 500); 19 Jun 2016 04:21:33 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 20365 invoked by uid 500); 19 Jun 2016 04:21:33 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 20346 invoked by uid 99); 19 Jun 2016 04:21:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 19 Jun 2016 04:21:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 752612CE53F; Sun, 19 Jun 2016 04:21:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6965453351904540007==" MIME-Version: 1.0 Subject: Re: Review Request 48915: Added an example framework for consuming GPUs. From: Mesos ReviewBot To: Benjamin Mahler Cc: Mesos ReviewBot , Kevin Klues , mesos Date: Sun, 19 Jun 2016 04:21:31 -0000 Message-ID: <20160619042131.4742.89105@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/48915/ X-Sender: Mesos ReviewBot References: <20160618221257.6755.58288@reviews.apache.org> In-Reply-To: <20160618221257.6755.58288@reviews.apache.org> X-ReviewBoard-Diff-For: src/examples/gpu_framework.cpp Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============6965453351904540007== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48915/#review138444 ----------------------------------------------------------- Patch looks great! Reviews applied: [48912, 48913, 48914, 48915] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 18, 2016, 10:12 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48915/ > ----------------------------------------------------------- > > (Updated June 18, 2016, 10:12 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5649 > https://issues.apache.org/jira/browse/MESOS-5649 > > > Repository: mesos > > > Description > ------- > > This framework is designed to show how to build a GPU capable > framework that can accept offers with GPUs and launch tasks that use > them. The key thing to remember is that the GPU_RESOURCES capability > must be set in `FrameworkInfo` in order for a framework to receive > resource offers from agents that contain GPUs. > > > Diffs > ----- > > src/Makefile.am a4931560f1a5b3fbe41ea181477341d3ac459b58 > src/examples/gpu_framework.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/48915/diff/ > > > Testing > ------- > > Run a master and an agent capable of handing out GPUs: > ``` > $ sudo bin/mesos-master.sh --ip=127.0.0.1 --log_dir=/var/log/mesos --work_dir=/var/lib/mesos > $ sudo bin/mesos-agent.sh --master=127.0.0.1:5050 --ip=127.0.0.1 --log_dir=/var/log/mesos --work_dir=/var/lib/mesos > --isolation="cgroups/devices,gpu/nvidia" > ``` > > Run a couple of instances of the framework and verify the correct output: > ``` > $ ./src/gpu-framework --master=127.0.0.1:5050 --num_gpus=0 > $ ./src/gpu-framework --master=127.0.0.1:5050 --num_gpus=1 > $ ./src/gpu-framework --master=127.0.0.1:5050 --num_gpus=4 > $ ./src/gpu-framework --master=127.0.0.1:5050 --no-allow_gpus --num_gpus=1 > ``` > > > Thanks, > > Kevin Klues > > --===============6965453351904540007==--