From reviews-return-35743-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Jun 4 16:56:52 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 56AE519A9E for ; Sat, 4 Jun 2016 16:56:52 +0000 (UTC) Received: (qmail 11292 invoked by uid 500); 4 Jun 2016 16:56:52 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 11261 invoked by uid 500); 4 Jun 2016 16:56:52 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 11237 invoked by uid 99); 4 Jun 2016 16:56:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Jun 2016 16:56:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F25E81DD926; Sat, 4 Jun 2016 16:56:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0909423804664076269==" MIME-Version: 1.0 Subject: Re: Review Request 45086: Enable cgroups unified isolator in isolation. From: Jie Yu To: Ian Downes , Alex Clemmer , Jie Yu , Guangya Liu , Kevin Klues , Gilbert Song Cc: Mesos ReviewBot , Qian Zhang , haosdent huang , mesos Date: Sat, 04 Jun 2016 16:56:50 -0000 Message-ID: <20160604165650.1106.3208@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45086/ X-Sender: Jie Yu References: <20160601150919.32447.18911@reviews.apache.org> In-Reply-To: <20160601150919.32447.18911@reviews.apache.org> Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============0909423804664076269== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 1, 2016, 3:09 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 265 > > > > > > I think you need to handle `cgroups/devices/gpus/nvidia` which also starts with `cgroups` :-) > > haosdent huang wrote: > Yes, when I post the first version of this. The gpu have not been submitted, I think it's time to add it now. :) I think for GPU, the plan is to rename it to gpu/nvidia. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/#review135801 ----------------------------------------------------------- On April 16, 2016, 10:29 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45086/ > ----------------------------------------------------------- > > (Updated April 16, 2016, 10:29 a.m.) > > > Review request for mesos, Gilbert Song, Guangya Liu, Alex Clemmer, Ian Downes, Jie Yu, and Kevin Klues. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Enable cgroups unified isolator in isolation. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp 1e1a36903f4377497bb72b69e4ead63675d453c0 > > Diff: https://reviews.apache.org/r/45086/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > > --===============0909423804664076269==--