From reviews-return-35742-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Jun 4 16:43:28 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2C61219A85 for ; Sat, 4 Jun 2016 16:43:28 +0000 (UTC) Received: (qmail 99939 invoked by uid 500); 4 Jun 2016 16:43:28 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 99910 invoked by uid 500); 4 Jun 2016 16:43:28 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 99893 invoked by uid 99); 4 Jun 2016 16:43:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Jun 2016 16:43:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E28D31DD926; Sat, 4 Jun 2016 16:43:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0569683949845076196==" MIME-Version: 1.0 Subject: Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator. From: haosdent huang To: Jie Yu , Kevin Klues , Ian Downes , Guangya Liu , Gilbert Song Cc: haosdent huang , mesos Date: Sat, 04 Jun 2016 16:43:26 -0000 Message-ID: <20160604164326.32447.69481@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: haosdent huang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/45574/ X-Sender: haosdent huang References: <20160416102857.29093.33263@reviews.apache.org> In-Reply-To: <20160416102857.29093.33263@reviews.apache.org> X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp Reply-To: haosdent huang X-ReviewRequest-Repository: mesos --===============0569683949845076196== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/#review136172 ----------------------------------------------------------- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (line 101) Would reach here if don't meet `Error`. - haosdent huang On April 16, 2016, 10:28 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45574/ > ----------------------------------------------------------- > > (Updated April 16, 2016, 10:28 a.m.) > > > Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues. > > > Bugs: MESOS-5047 > https://issues.apache.org/jira/browse/MESOS-5047 > > > Repository: mesos > > > Description > ------- > > Add `PerfEventSubsystem` for cgroups unified isolator. > > > Diffs > ----- > > src/linux/perf.hpp 674d5f886ea41b939a8e48832ee6595a78b2f6ce > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/45574/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > > --===============0569683949845076196==--