mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49444: Added a helper function to construct JSON:Object from FileInfo protobuf.
Date Thu, 30 Jun 2016 21:03:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49444/#review140236
-----------------------------------------------------------


Fix it, then Ship it!





src/common/http.cpp (line 396)
<https://reviews.apache.org/r/49444/#comment205561>

    whoops, this is of type `time_t` and has a precision of seconds. This would break someone
relying on it in the old API.


- Anand Mazumdar


On June 30, 2016, 2:06 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49444/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 2:06 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5487
>     https://issues.apache.org/jira/browse/MESOS-5487
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a helper function to construct JSON:Object from FileInfo protobuf.
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp 55bd0ac81af80c656a4a80766a3e4b21db9cf0cf 
>   src/common/http.cpp daf5672287bb6633f468c88632a561f5a01590df 
> 
> Diff: https://reviews.apache.org/r/49444/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message