mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49443: Include a function to construct FileInfo protobuf message.
Date Thu, 30 Jun 2016 20:56:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49443/#review140221
-----------------------------------------------------------



Looks good! Left a few minor cleanup/style comments.


src/common/protobuf_utils.hpp (lines 20 - 26)
<https://reviews.apache.org/r/49443/#comment205537>

    Move these include to the cpp where they are used.
    
    Also, can you audit `src/files/files.hpp` and remove the includes from there if no longer
used?



src/common/protobuf_utils.hpp (line 49)
<https://reviews.apache.org/r/49443/#comment205538>

    Move to cpp



src/common/protobuf_utils.hpp (lines 53 - 55)
<https://reviews.apache.org/r/49443/#comment205539>

    Move this to the cpp file.



src/common/protobuf_utils.hpp (lines 119 - 121)
<https://reviews.apache.org/r/49443/#comment205541>

    We already _explained_ `FileInfo` as part of the corresponding protobuf. Let's document
here the business logic of the function `createFileInfo()`.
    
    How about:
    ```cpp
    // Helper function that creates a `FileInfo` from data returned by `stat()`.
    ```



src/common/protobuf_utils.hpp (lines 123 - 124)
<https://reviews.apache.org/r/49443/#comment205552>

    Should fit in one line.



src/common/protobuf_utils.cpp (line 290)
<https://reviews.apache.org/r/49443/#comment205551>

    Should fit in one line?
    
    Also, indent was wrong. We indent arguments by 4 spaces.


- Anand Mazumdar


On June 30, 2016, 2:05 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49443/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 2:05 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5487
>     https://issues.apache.org/jira/browse/MESOS-5487
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Include a function to construct FileInfo protobuf message.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.hpp 3dd03da3fea10a01aa4508f53c5d1ebcc3d6a2a4 
>   src/common/protobuf_utils.cpp 040bdf82134289f0caf63e11c2ce8e7853a392b3 
> 
> Diff: https://reviews.apache.org/r/49443/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message