mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 49369: Introduced authorization based filtering for /roles.
Date Thu, 30 Jun 2016 19:36:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49369/
-----------------------------------------------------------

(Updated June 30, 2016, 7:36 p.m.)


Review request for mesos and Adam B.


Changes
-------

Rebased.


Bugs: MESOS-5709
    https://issues.apache.org/jira/browse/MESOS-5709


Repository: mesos


Description
-------

Previously only /weights was filtered but /roles actually
contains the same information and hence both endpoints
should be filtered in the same way.
As part of this work we renamed the GetWeight action to
ViewRole (and same for the acls).


Diffs (updated)
-----

  include/mesos/authorizer/acls.proto a6d93cd2cb9161a98565b22e50b06aac4931a671 
  include/mesos/authorizer/authorizer.proto fc76796022a6fa3d36a1447c476980868d42c2d0 
  src/authorizer/local/authorizer.cpp 3fade4168face1cb80b30c9b69b31d9eb4126222 
  src/common/http.hpp 55bd0ac81af80c656a4a80766a3e4b21db9cf0cf 
  src/common/http.cpp daf5672287bb6633f468c88632a561f5a01590df 
  src/master/http.cpp 670b4e0e4424400d138fdf4ca1493520c90b6448 
  src/master/weights_handler.cpp 5fc69c6a1c2663bad1774d9376b0aa9f90fa7275 
  src/tests/authorization_tests.cpp 9b99da138fa27a725738d70bd99e889b108b44ae 
  src/tests/dynamic_weights_tests.cpp c67ed75a050b9db5575ac2bb6100bcf01cfc04ff 
  src/tests/master_authorization_tests.cpp 207dfb293ea9b70f439b3b391c3feeba7da10c6a 

Diff: https://reviews.apache.org/r/49369/diff/


Testing
-------

sudo make check


Thanks,

Joerg Schad


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message