mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 49418: Decoupled implementation of `tasks()` and `getTasks()` in master.
Date Thu, 30 Jun 2016 16:53:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49418/#review140182
-----------------------------------------------------------


Fix it, then Ship it!





src/master/http.cpp (lines 3115 - 3117)
<https://reviews.apache.org/r/49418/#comment205497>

    Indent off.


- Anand Mazumdar


On June 30, 2016, 1:33 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49418/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 1:33 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jay Guo, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The response of `getTasks()` is going to look different from that of
> `tasks()`, so it doesn't make sense to couple their implementations.
> Note that this is pure code movement, there is no functional change.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp e5acdb8e0bbcd7a2b7e8a8bc7f4bbeaae2c4fea1 
> 
> Diff: https://reviews.apache.org/r/49418/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message