mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 49394: Added support for VIEW_FLAGS authorization action in HTTP API.
Date Thu, 30 Jun 2016 15:03:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49394/
-----------------------------------------------------------

(Updated June 30, 2016, 5:03 p.m.)


Review request for mesos, Adam B and Vinod Kone.


Changes
-------

Removes piece that doesn't compile in GCC because of visibility of `Master::Http` and changed
for a _TODO_.


Bugs: MESOS-5705
    https://issues.apache.org/jira/browse/MESOS-5705


Repository: mesos


Description
-------

Adds an intermediate function `Master::http::_flags()` which performs
authorization and it is called by both the endpoint `/flags` handler
and the HTTP API v1 call `flags` handler.


Diffs (updated)
-----

  src/master/http.cpp e5acdb8e0bbcd7a2b7e8a8bc7f4bbeaae2c4fea1 
  src/master/master.hpp e2ab2110fe5a287ab16ac9ef4222fed633e02ebe 

Diff: https://reviews.apache.org/r/49394/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message