mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 49375: Simplified DRFSorter to not track per-slave total resources.
Date Wed, 29 Jun 2016 13:43:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49375/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and Michael Park.


Bugs: MESOS-5698
    https://issues.apache.org/jira/browse/MESOS-5698


Repository: mesos


Description
-------

The DRFSorter previously kept the total resources at each slave, along
with the total quantity of resources in the cluster. The latter figure
is what most of the clients of the sorter care about. In the few places
where the previous coding was using the per-slave total resources, it is
relatively easy to adjust the code to remove this dependency.

As part of this change, remove `total()` and `update(const SlaveID&
slaveId, const Resources& resources)` from the Sorter interface. The
former was unused; for the latter, code that used it can instead be
rewritten to adjust the total resources in the cluster by first removing
the previous resources at a slave and then adding the new resources.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp c3639342335499a04a23147a4205f1b475c123fa 
  src/master/allocator/sorter/drf/sorter.hpp 35273b5dcf39938125a112c5e56b5a8a542157db 
  src/master/allocator/sorter/drf/sorter.cpp 27d56f274c41bbabe6f2abbbcebd2c4eff52693e 
  src/master/allocator/sorter/sorter.hpp 68a2f56cef976203d83ed823486d1a9675f9ab68 
  src/tests/sorter_tests.cpp 6fc58829892dc0223140f1b47593a3e5853cace5 

Diff: https://reviews.apache.org/r/49375/diff/


Testing
-------

make check on OSX and recent Arch Linux.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message