mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49219: Added runtime isolator interface to run appc containers.
Date Wed, 29 Jun 2016 13:27:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49219/#review139982
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 51)
<https://reviews.apache.org/r/49219/#comment205323>

    Please keep two lines for each function.
    
    Seems you uploaded this patch by mistake? I saw that you marked all comments as fixed
but the patch was not updated based on comments?



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 77)
<https://reviews.apache.org/r/49219/#comment205324>

    1) s/appc/AppC
    2) Add a period to the end


- Guangya Liu


On 六月 29, 2016, 12:46 a.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49219/
> -----------------------------------------------------------
> 
> (Updated 六月 29, 2016, 12:46 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4778
>     https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added runtime isolator interface to run appc containers.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 9c80a613818302ad3b417d582e9a91a59a6f666d 
>   src/Makefile.am 86c39fdf379ada470c9b1f86be263ef71dc47c41 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49219/diff/
> 
> 
> Testing
> -------
> 
> Make Check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message