mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Re: Review Request 49297: Use defer() to garantee getTasks lambda execution context.
Date Wed, 29 Jun 2016 05:10:37 GMT


> On June 28, 2016, 8:45 p.m., Vinod Kone wrote:
> > Maybe it's better for getTasks() to have it's own independation implementation instead
of depending on the factored out `_tasks()`. getAgents() and getFrameworks() have their own
implementations anyway. We can also revert the `_tasks()` split. We need to add comments for
why we have own independent implementations for getTasks(), getAgents() and getFrameworks()
for posterity.
> > 
> > What do you think?

We could also take json and evolve it to v1Response, like `getContainers`. But I guess standalone
implementation makes more sense if we want to embed `getTasks` into other responses.


- Jay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49297/#review139856
-----------------------------------------------------------


On June 28, 2016, 7:23 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49297/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 7:23 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use defer() to garantee getTasks lambda execution context.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp d583bbeb186974135999eaddbab96e69635dcc7c 
> 
> Diff: https://reviews.apache.org/r/49297/diff/
> 
> 
> Testing
> -------
> 
> WIP
> 
> make check
> 
> Still need to figure out how to handle invalid task*
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message