mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 49321: GetState response protobuf.
Date Wed, 29 Jun 2016 02:09:23 GMT


> On June 28, 2016, 10:50 p.m., Zhitao Li wrote:
> > include/mesos/master/master.proto, line 282
> > <https://reviews.apache.org/r/49321/diff/1/?file=1431925#file1431925line282>
> >
> >     Can elected_time actually be optional? Assuming we only serve from elected leader
or error out in response, this could be required to be consistent with other fields.
> >     
> >     It remains a question whether we want to make `GetFrameworks get_frameworks`
optional: making it required might make future implementation of filters difficult, depending
on how filters will be implemented.

Got it, let me drop :)


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49321/#review139887
-----------------------------------------------------------


On June 28, 2016, 3:07 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49321/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 3:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5489
>     https://issues.apache.org/jira/browse/MESOS-5489
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> GetState response protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 332261918a069f4e581bfc4d0fc14ce8c86c2617 
>   include/mesos/v1/master/master.proto 681ea1e638777059a6bf792435cbe526bc252f7a 
> 
> Diff: https://reviews.apache.org/r/49321/diff/
> 
> 
> Testing
> -------
> 
> `make` on Mac
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message