mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 46887: Added the HTTP GET authorization action to the documentation.
Date Mon, 27 Jun 2016 10:06:35 GMT


> On June 14, 2016, 3:13 p.m., Joerg Schad wrote:
> >

Given that Jörg is busy to finish this patch, It get's superseeded by [r/49257/](https://reviews.apache.org/r/49257/)


> On June 14, 2016, 3:13 p.m., Joerg Schad wrote:
> > docs/authorization.md, line 140
> > <https://reviews.apache.org/r/46887/diff/2/?file=1418305#file1418305line140>
> >
> >     Could we
> >     a) check that the HTTP HELP text is correct for all these endpoints (i.e, mentions
AUTHORIZATION)
> >     b) mention here that the HTTP endpoint HELP contains information about this?
> >     
> >     s/supports/covers (as it does not allow individual endpoints, it is a all or
nothing decision)
> 
> Joerg Schad wrote:
>     Forget the seconds part i.e, covers....
> 
> Jan Schlicht wrote:
>     Something similar has been added by another ticket, e.g. listing all endpoints that
are authorizable. I'd suggest we use that instead of providing it in this RR.

Checked, the endpoints already have the right documentation.


> On June 14, 2016, 3:13 p.m., Joerg Schad wrote:
> > docs/authorization.md, line 601
> > <https://reviews.apache.org/r/46887/diff/2/?file=1418305#file1418305line601>
> >
> >     .. endpoints (due to the `permissive = false`).

I don't this is necessary since the comment is not included in any other example and there
is already a description on how `permissive: false` works.


> On June 14, 2016, 3:13 p.m., Joerg Schad wrote:
> > docs/upgrades.md, line 75
> > <https://reviews.apache.org/r/46887/diff/2/?file=1418306#file1418306line75>
> >
> >     can you double check that label is still available (I believe I saw/wrote another
patch using that label).
> 
> Jan Schlicht wrote:
>     There's a similar label, that's just recently been added and that's documenting (IMO)
the same upgrade informations as in this RR. I'd suggest that we remove the upgrade instructions
here and stick to the existing ones.

Adding a new section shouldn't be done since a couple of lines belowthere is already: `#1-0-x-endpoint-authorization`.
It is better to reuse that one.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46887/#review137495
-----------------------------------------------------------


On June 14, 2016, 1:46 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46887/
> -----------------------------------------------------------
> 
> (Updated June 14, 2016, 1:46 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Joerg Schad, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the HTTP GET authorization action to the documentation.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 0df0d4ccd76379ede6492e595999711e5462f79b 
>   docs/authorization.md dcf2160424771c513579063911cc14792f464821 
>   docs/upgrades.md afc76f7a0e74042bd095b925f8119bfa5daa489c 
> 
> Diff: https://reviews.apache.org/r/46887/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message