mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 48704: Updated FilesProcess to support List_Files Call in Operator API v1.
Date Mon, 20 Jun 2016 17:05:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48704/#review138632
-----------------------------------------------------------




src/files/files.hpp (line 83)
<https://reviews.apache.org/r/48704/#comment203830>

    I think we may consider create a extra function only return file list. So that we no need
to parse `JSON::Array` in following patches.


- haosdent huang


On June 14, 2016, 7:19 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48704/
> -----------------------------------------------------------
> 
> (Updated June 14, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5514
>     https://issues.apache.org/jira/browse/MESOS-5514
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated FilesProcess to support List_Files Call in Operator API v1.
> 
> 
> Diffs
> -----
> 
>   src/files/files.hpp b767d5bc5bee16e3bd98199773a6bc7d30c1c32d 
>   src/files/files.cpp 20bc6fa0c22ab017c4e23a745c313a3caf0aec36 
> 
> Diff: https://reviews.apache.org/r/48704/diff/
> 
> 
> Testing
> -------
> 
> Ubuntu 16.04:
> 
> sudo GTEST_FILTER="FilesTest.BrowseTest" make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message