mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 48948: Fix getTasks() to use unversioned protobuf.
Date Mon, 20 Jun 2016 16:07:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48948/#review138616
-----------------------------------------------------------



Bad patch!

Reviews applied: [48948]

Failed command: ./support/apply-review.sh -n -r 48948

Error:
2016-06-20 16:07:41 URL:https://reviews.apache.org/r/48948/diff/raw/ [1579/1579] -> "48948.patch"
[1]
error: patch failed: src/master/http.cpp:1516
error: src/master/http.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13907/console

- Mesos ReviewBot


On June 20, 2016, 9:35 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48948/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 9:35 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5493
>     https://issues.apache.org/jira/browse/MESOS-5493
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> v1::master::Response was still used internally. This fixes the
> implementation to use unversioned mesos::master::Response.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto b3ce61d27af539430b2d15263ab7d09197895823 
>   src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
> 
> Diff: https://reviews.apache.org/r/48948/diff/
> 
> 
> Testing
> -------
> 
> make check on OSX & Ubuntu 14.04
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message