mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 48902: Move v1/master/allocator.proto to its own package.
Date Mon, 20 Jun 2016 14:59:05 GMT


> On June 20, 2016, 8:06 a.m., Alexander Rukletsov wrote:
> > To avoid confusion, we should actually change the namespace allocator code lives
is as well. I've once started that effort (https://reviews.apache.org/r/29930/) but decided
to discard because allocator is the master-only component.

Alexander, so what's your recommendation here? Given that there is only one public visible
message `InverseOfferStatus` in this protobuf at the moment, I'd like to have a quick fix
to make sure its namespace does not change after v1.0 and catch the release deadline.

If "allocator is the master-only component" is considered a good reason to keep these code
in master namespace, then the question is how to handle maintenance which could have circular
dependency to master components: maybe we should just move this message to `mesos` namespace
as other high level messages like `Offer` or `TaskStatus`?


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48902/#review138546
-----------------------------------------------------------


On June 18, 2016, 6:36 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48902/
> -----------------------------------------------------------
> 
> (Updated June 18, 2016, 6:36 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5642
>     https://issues.apache.org/jira/browse/MESOS-5642
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Move v1/master/allocator.proto to its own package.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/maintenance/maintenance.proto 053d72d7d9fa9ec8f572136020546fa4f955ab09

>   include/mesos/v1/master/allocator.proto cf416d173bc487aecbbec75c9ee391a54bf5327b 
>   src/CMakeLists.txt d66186217c1319d4497640614ed4beee28602c38 
>   src/Makefile.am a4931560f1a5b3fbe41ea181477341d3ac459b58 
> 
> Diff: https://reviews.apache.org/r/48902/diff/
> 
> 
> Testing
> -------
> 
> run `make` on Mac.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message