mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 48936: Explained why fields in the acts.Entity must be required.
Date Mon, 20 Jun 2016 13:31:59 GMT


> On June 20, 2016, 12:19 p.m., Till Toenshoff wrote:
> > include/mesos/authorizer/acls.proto, lines 34-35
> > <https://reviews.apache.org/r/48936/diff/1/?file=1423750#file1423750line34>
> >
> >     The above note seems to be targetted towards the users/consumers of these messages
whereas the new note is targeted towards Mesos developers, warning them to not break the pattern.
> >     
> >     I feel we should change the style here to make that more obvious.
> >     
> >     How about:
> >     
> >     ```
> >     NOTE: When adding new actions to these proto definitions that entities in these
messages are `required`. Absent ...
> >     ```

Good! I'll change to 
```
  // NOTE: When adding new actions to these proto definitions,
  // declare entities in these messages as `required`. Absent
  // `Entity` is ambiguous: it can be interpreted as `NONE` or `ANY`.
```


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48936/#review138507
-----------------------------------------------------------


On June 20, 2016, 12:12 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48936/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 12:12 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Till Toenshoff.
> 
> 
> Bugs: MESOS-5588
>     https://issues.apache.org/jira/browse/MESOS-5588
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto f8e866b876c49e62a07f29edc66fc205ff33d618 
> 
> Diff: https://reviews.apache.org/r/48936/diff/
> 
> 
> Testing
> -------
> 
> None: Not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message