mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jose Guilherme Vanz <guilherme....@gmail.com>
Subject Re: Review Request 48387: Delay before initiating a connection with master.
Date Mon, 20 Jun 2016 10:02:02 GMT


> On June 20, 2016, 6:51 a.m., haosdent huang wrote:
> > src/tests/mesos.cpp, line 84
> > <https://reviews.apache.org/r/48387/diff/6/?file=1425175#file1425175line84>
> >
> >     Usually we don't set flag in this way. We prefer to modify `master::Flags MesosTest::CreateMasterFlags()`
in `src/tests/mesos.cpp`.
> >     
> >     Please see how we set global master flags for default test cases there.

The MESOS_CONNECTION_DELAY_MAX is not a master's flag, it is a scheduler's flag. It is not
possible pass it as a parameter. It's loaded from enviroment variables only.


- Jose Guilherme


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48387/#review138568
-----------------------------------------------------------


On June 20, 2016, 6:38 a.m., Jose Guilherme Vanz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48387/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 6:38 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-5359
>     https://issues.apache.org/jira/browse/MESOS-5359
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The scheduler library has been updated to wait a little deley before
> initiate a connection with the master. The maximum amount of time waited
> by the scheduler is defined by a flag: CONNECTION_DELAY_MAX. After
> the master has been detected the scheduler picks a random delay that
> can be between 0 and the CONNECTION_DELAY_MAX value. MESOS-5359
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a4931560f1a5b3fbe41ea181477341d3ac459b58 
>   src/scheduler/constants.hpp PRE-CREATION 
>   src/scheduler/flags.hpp PRE-CREATION 
>   src/scheduler/scheduler.cpp c79837c93e7329dbfa22e4288b44237f33408ba9 
>   src/tests/http_fault_tolerance_tests.cpp baa07395b9bd588daa5438369954584787d7952a 
>   src/tests/master_maintenance_tests.cpp a8649fdf3cbd4996d1528393506b1b0ed0a7cf5c 
>   src/tests/mesos.hpp 6bd3a708db450eae21bd5c59f74c811bf87b3c89 
>   src/tests/mesos.cpp e7792fde39a60536f9651f75f1cbfa09b28651a9 
> 
> Diff: https://reviews.apache.org/r/48387/diff/
> 
> 
> Testing
> -------
> 
> mesos-tests
> 
> 
> Thanks,
> 
> Jose Guilherme Vanz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message