mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 46501: Updated authorization.md to reflect current changes.
Date Mon, 20 Jun 2016 09:39:01 GMT


> On May 18, 2016, 12:17 p.m., Alexander Rukletsov wrote:
> > docs/authorization.md, lines 125-136
> > <https://reviews.apache.org/r/46501/diff/8/?file=1385425#file1385425line125>
> >
> >     According to https://mesos.apache.org/documentation/latest/markdown-style-guide/
, we should use HTML tables. Could you please follow-up with the fix? Feel free to publish
a review without a JIRA ticket. Thanks!

fixed in review [r/48947/](https://reviews.apache.org/r/48947/)


> On May 18, 2016, 12:17 p.m., Alexander Rukletsov wrote:
> > docs/authorization.md, line 136
> > <https://reviews.apache.org/r/46501/diff/8/?file=1385425#file1385425line136>
> >
> >     We should add an entry for `get_endpoints`

Addressed in review [r/46887/](https://reviews.apache.org/r/46887/)


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46501/#review133711
-----------------------------------------------------------


On May 17, 2016, 3:11 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46501/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 3:11 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Neil Conway.
> 
> 
> Bugs: MESOS-4785
>     https://issues.apache.org/jira/browse/MESOS-4785
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The API of the authorization has been changing constantly over the
> last few versions. This patch attempts to update the documentation to
> the those changes into account.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
> 
> Diff: https://reviews.apache.org/r/46501/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message