mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 48942: Remove unnecessary inclusion of allocator proto header from makefile.
Date Mon, 20 Jun 2016 08:26:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48942/#review138555
-----------------------------------------------------------



Hmm, not sure this does what you want. In today's `master` `7d27e3acebe5a23b93a0eea3739107838804be8a`
I only see `allocator.proto` in `v1master_HEADERS` while there is `allocator.pb.h` in `nodist_v1master_HEADERS`
-- note the differing extentions. Adding the first one ensure that the proto source `allocator.proto`
is included in a distributed archive, while the second one declares the actual dependency
on the produced output `allocator.pb.h` which should not be part of the distrution archive.

Removing the dependency egde as suggest here could break parallel builds as `v1quota` might
be started before the proto output is generated

- Benjamin Bannier


On June 20, 2016, 10:08 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48942/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 10:08 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5509
>     https://issues.apache.org/jira/browse/MESOS-5509
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> allocator.pb.h is already present in v1master_HEADERS , so excluded that
> from nodist_v1quota_HEADERS in src/Makefile.am.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a4931560f1a5b3fbe41ea181477341d3ac459b58 
> 
> Diff: https://reviews.apache.org/r/48942/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message