mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.
Date Mon, 20 Jun 2016 01:30:53 GMT


> On June 20, 2016, 12:34 a.m., Vinod Kone wrote:
> > docs/upgrades.md, line 262
> > <https://reviews.apache.org/r/48928/diff/1/?file=1423596#file1423596line262>
> >
> >     Is libelf a run-time dep as well? I thought it was a build-time dep only? I'm
thinking more and more that we should guard this dep on a config or run time flag. cc @bmahler.

Yes, it's a runtime dependence.  The headers are a build-time dependence and then the library
itself is a runtime dependence. Honestly, for this release it's not even necessary to pull
in this dependence yet, as none of the committed code uses it yet (other than a test). It
is only used for anything substantial by stuff that won't make it until the next release.
 If you want me to submit a patch to just remove it for now so we can think about the best
way forward for the next release, let me know.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48928/#review138506
-----------------------------------------------------------


On June 19, 2016, 7:30 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48928/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 7:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, haosdent huang, Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-5630
>     https://issues.apache.org/jira/browse/MESOS-5630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added info about external `libelf` dependence to `upgrades.md`.
> 
> 
> Diffs
> -----
> 
>   docs/upgrades.md 61b7cd3ab45d09f3e4785e00bb8622421952d253 
> 
> Diff: https://reviews.apache.org/r/48928/diff/
> 
> 
> Testing
> -------
> 
> Ran the site docker to verify everything looked OK.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message