mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.
Date Mon, 20 Jun 2016 00:56:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48438/#review138345
-----------------------------------------------------------




src/master/http.cpp (line 1706)
<https://reviews.apache.org/r/48438/#comment203513>

    s/agent/slave/
    
    calling Slave* agent is a bit confusing.



src/master/http.cpp (line 1707)
<https://reviews.apache.org/r/48438/#comment203514>

    s/agentObject/agent/



src/master/http.cpp (lines 1733 - 1742)
<https://reviews.apache.org/r/48438/#comment203528>

    you can kill this.



src/master/http.cpp (lines 1744 - 1746)
<https://reviews.apache.org/r/48438/#comment203529>

    you can kill this.


- Vinod Kone


On June 18, 2016, 2:02 p.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48438/
> -----------------------------------------------------------
> 
> (Updated June 18, 2016, 2:02 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5491
>     https://issues.apache.org/jira/browse/mesos-5491
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implement the basic getAgents method for v1 operator master API.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp a6beb1721958a77886f0aa535346e2ff33bd5d04 
>   src/master/master.hpp 618d928ef1398e7397df968c7cd47acbc987d1e3 
>   src/tests/api_tests.cpp afa5ffab8729dfc5b102968ec64c6a3bcd832dfd 
> 
> Diff: https://reviews.apache.org/r/48438/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message