mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 48056: Windows: Added build and run instructions.
Date Sun, 19 Jun 2016 23:20:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48056/#review138485
-----------------------------------------------------------



Possibly missing some steps related to OpenSSL.  Here's what I got while building the curl
dependency (for example):

```
1>  -- Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the system
variable OPENSSL_ROOT_DIR (missing:  OPENSSL_LIBRARIES OPENSSL_INCLUDE_DIR)
1>  CMake Warning at CMakeLists.txt:462 (find_package):
1>    By not providing "FindLibSSH2.cmake" in CMAKE_MODULE_PATH this project has
1>    asked CMake to find a package configuration file provided by "LibSSH2", but
1>    CMake did not find one.
1>
1>    Could not find a package configuration file provided by "LibSSH2" with any
1>    of the following names:
1>
1>      LibSSH2Config.cmake
1>      libssh2-config.cmake
1>
1>    Add the installation prefix of "LibSSH2" to CMAKE_PREFIX_PATH or set
1>    "LibSSH2_DIR" to a directory containing one of the above files.  If
1>    "LibSSH2" provides a separate development package or SDK, be sure it has
1>    been installed.
1>
1>
1>  CMake Error at CMake/OtherTests.cmake:86 (message):
1>    Unable to link function recv
1>  Call Stack (most recent call first):
1>    CMakeLists.txt:988 (include)
1>
1>
1>  -- Configuring incomplete, errors occurred!
```


docs/getting-started.md (line 207)
<https://reviews.apache.org/r/48056/#comment203676>

    Add a note here:
    
    This can be found by opening VS2015 and looking under the "tools" menu for "Visual Studio
Command Prompt".



docs/getting-started.md (line 215)
<https://reviews.apache.org/r/48056/#comment203667>

    s/-DENABLE_LIB_EVENT/-DENABLE_LIBEVENT/
    
    Looks like we also need to specify:
    `cmake -G "Visual Studio 14 2015 Win64" ..`



docs/getting-started.md (line 227)
<https://reviews.apache.org/r/48056/#comment203669>

    Space at the beginning, period at the end.



docs/getting-started.md (line 230)
<https://reviews.apache.org/r/48056/#comment203670>

    Minor nits (spacing, capitalization, period).


- Joseph Wu


On June 15, 2016, 11:19 a.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48056/
> -----------------------------------------------------------
> 
> (Updated June 15, 2016, 11:19 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere,
and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added build and run instructions.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 8c72e5ec1263adb8792c8c49ede50bbf649e1ef3 
> 
> Diff: https://reviews.apache.org/r/48056/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message