mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 48918: Removed explicit authorization results in Mesos.
Date Sun, 19 Jun 2016 23:03:33 GMT


> On June 19, 2016, 10:40 p.m., Alexander Rukletsov wrote:
> > src/slave/http.cpp, lines 1089-1093
> > <https://reviews.apache.org/r/48918/diff/1/?file=1423491#file1423491line1089>
> >
> >     How about this one?

Nope, that one will not get invoked if the authorizer failed - `containers` will already return
the failed future, `_containers` then never gets invoked.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48918/#review138488
-----------------------------------------------------------


On June 19, 2016, 3:02 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48918/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 3:02 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Benjamin Mahler,
Greg Mann, and Kapil Arya.
> 
> 
> Bugs: MESOS-5637
>     https://issues.apache.org/jira/browse/MESOS-5637
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removing the explicit authorization results as formerly returned by
> some authorizer invocations in Mesos, the returned future falls
> through/back to the HTTP proxy handler of libprocess. This change
> allows us to reduce the amount of failure result handlers.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp a6beb1721958a77886f0aa535346e2ff33bd5d04 
>   src/slave/http.cpp 77834111bf51b58ba5e12f262b725202f7d3a7bf 
> 
> Diff: https://reviews.apache.org/r/48918/diff/
> 
> 
> Testing
> -------
> 
> make check & functional testing.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message