mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Review Request 48934: Removed redundant expectations for `connected`/`disconnected` callback.
Date Sun, 19 Jun 2016 22:47:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48934/
-----------------------------------------------------------

Review request for mesos, Jose Guilherme Vanz and Vinod Kone.


Repository: mesos


Description
-------

This is a follow up patch to `625b08` with the same reasoning i.e.,
the `master` object is now destroyed _after_ the scheduler
library thereby ensuring that there cannot be any pending callbacks
that can be triggered. Hence, we can get rid of these redundant
expectations.


Diffs
-----

  src/tests/http_fault_tolerance_tests.cpp baa07395b9bd588daa5438369954584787d7952a 
  src/tests/scheduler_tests.cpp b1831052ef2ef4bc4f8f6ecabbb95f309378fa25 

Diff: https://reviews.apache.org/r/48934/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message