mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 48933: Fixed build on machines that contain GPU's.
Date Sun, 19 Jun 2016 21:58:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48933/#review138484
-----------------------------------------------------------


Ship it!




Looks good:

Ran `GTEST_FILTER="*GetRoles*" make -j check`

on my GPU machine and it all passes now.

```
[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from ContentType/MasterAPITest
[ RUN      ] ContentType/MasterAPITest.GetRoles/0
[       OK ] ContentType/MasterAPITest.GetRoles/0 (249 ms)
[ RUN      ] ContentType/MasterAPITest.GetRoles/1
[       OK ] ContentType/MasterAPITest.GetRoles/1 (177 ms)
[----------] 2 tests from ContentType/MasterAPITest (427 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (458 ms total)
[  PASSED  ] 2 tests.
```

- Kevin Klues


On June 19, 2016, 9:47 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48933/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 9:47 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-5494
>     https://issues.apache.org/jira/browse/MESOS-5494
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change modifies a test that was explicitly setting the GPU
> resource. This broke the build on machines that actually
> had a GPU device present.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf 
> 
> Diff: https://reviews.apache.org/r/48933/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message