mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 48915: Added an example framework for consuming GPUs.
Date Sun, 19 Jun 2016 21:15:24 GMT


> On June 19, 2016, 7:13 a.m., Guangya Liu wrote:
> > It is better re-implement your framework with v1 API, you can take a look at https://github.com/apache/mesos/blob/master/src/examples/long_lived_framework.cpp
as an referene.

The `MesosSchedulerDriver` is implemented in terms of the v1 API, and covers alot more corner
cases than the `long_lived_framework` does. I realize it's important to implement *some* example
frameworks in terms of the new API, but it feels odd to me to have to implement all new framework
in terms of the raw HTTP API since wrappers for C++ exist.


> On June 19, 2016, 7:13 a.m., Guangya Liu wrote:
> > src/examples/gpu_framework.cpp, line 51
> > <https://reviews.apache.org/r/48915/diff/1/?file=1423483#file1423483line51>
> >
> >     s/TestScheduler/GPUScheduler

Updated


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48915/#review138447
-----------------------------------------------------------


On June 19, 2016, 9:01 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48915/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 9:01 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5649
>     https://issues.apache.org/jira/browse/MESOS-5649
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This framework is designed to show how to build a GPU capable
> framework that can accept offers with GPUs and launch tasks that use
> them. The key thing to remember is that the GPU_RESOURCES capability
> must be set in `FrameworkInfo` in order for a framework to receive
> resource offers from agents that contain GPUs.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a4931560f1a5b3fbe41ea181477341d3ac459b58 
>   src/examples/gpu_framework.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48915/diff/
> 
> 
> Testing
> -------
> 
> Run a master and an agent capable of handing out GPUs:
> ```
> $ sudo bin/mesos-master.sh --ip=127.0.0.1 --log_dir=/var/log/mesos --work_dir=/var/lib/mesos
> $ sudo bin/mesos-agent.sh --master=127.0.0.1:5050 --ip=127.0.0.1 --log_dir=/var/log/mesos
--work_dir=/var/lib/mesos
>                           --isolation="cgroups/devices,gpu/nvidia"
> ```
> 
> Run a couple of instances of the framework and verify the correct output:
> ```
> $ ./src/gpu-framework --master=127.0.0.1:5050 --num_gpus=0
> $ ./src/gpu-framework --master=127.0.0.1:5050 --num_gpus=1
> $ ./src/gpu-framework --master=127.0.0.1:5050 --num_gpus=4
> $ ./src/gpu-framework --master=127.0.0.1:5050 --no-allow_gpus --num_gpus=1
> ```
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message