mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.
Date Sun, 19 Jun 2016 17:10:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48925/#review138472
-----------------------------------------------------------



LGTM except the style issue @tillt mentioned.


src/master/weights_handler.cpp (lines 88 - 89)
<https://reviews.apache.org/r/48925/#comment203647>

    Suggest to capture exactly here as well.
    ```
      return _getWeights(principal)
        .then([contentType](const vector<WeightInfo>& weightInfos)
          -> Future<http::Response> {
    ```


- haosdent huang


On June 19, 2016, 12:01 p.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48925/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 12:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5495
>     https://issues.apache.org/jira/browse/mesos-5495
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add getWeights method in weights_handler.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe 
>   src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d 
>   src/master/weights_handler.cpp 25075357c5ac8450d2fa1790844802f121908e9e 
>   src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf 
> 
> Diff: https://reviews.apache.org/r/48925/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message