mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 45086: Enable cgroups unified isolator in isolation.
Date Sun, 19 Jun 2016 16:51:45 GMT


> On June 1, 2016, 3:09 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 265
> > <https://reviews.apache.org/r/45086/diff/13/?file=1347681#file1347681line265>
> >
> >     I think you need to handle `cgroups/devices/gpus/nvidia` which also starts with
`cgroups` :-)
> 
> haosdent huang wrote:
>     Yes, when I post the first version of this. The gpu have not been submitted, I think
it's time to add it now. :)
> 
> Jie Yu wrote:
>     I think for GPU, the plan is to rename it to gpu/nvidia.
> 
> haosdent huang wrote:
>     Does this mean we not need to consider gpu isolators when we implement this?
> 
> Qian Zhang wrote:
>     In https://reviews.apache.org/r/48478 , I see `cgroups/devices/gpus/nvidia` isolator
has been divided into 2 isolators: `gpu/nvidia` and `cgroups/devices`, so I think we still
need to handle `cgruops/devices` which starts with `cgroups`.

Create a ticket here for `DevicesSubsystem` at https://issues.apache.org/jira/browse/MESOS-5651.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45086/#review135801
-----------------------------------------------------------


On June 19, 2016, 4:50 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45086/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 4:50 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, Kevin Klues,
and Qian Zhang.
> 
> 
> Bugs: MESOS-5041
>     https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable cgroups unified isolator in isolation.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp d6a91113da322dc58e1d3dd3e03353631b6dafee

> 
> Diff: https://reviews.apache.org/r/45086/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message