mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 46158: Completed implementation of the cgroups unified isolator.
Date Sun, 19 Jun 2016 15:35:52 GMT


> On June 15, 2016, 1:12 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 74
> > <https://reviews.apache.org/r/46158/diff/2/?file=1347650#file1347650line74>
> >
> >     Can you please clarfiy why we want to have `user` as a field of `Info` class?
Basically, I do not think `Info` class should have such field.

I think a complete container info structure for cgroup should indicate which user it belongs
to, so I add this before. Could remove it here.


> On June 15, 2016, 1:12 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 425
> > <https://reviews.apache.org/r/46158/diff/2/?file=1347650#file1347650line425>
> >
> >     Can you please clarify why we need the `pid` field in the `Info` class? This
is the only place I see we assign value to `Info::pid`, but it seems we never use this field?
Basically, I do not think we should have such field in `Info` class.

I think a complete container info structure for cgroup should contain the pid isolated, so
I add this before. Could remove it here.


> On June 15, 2016, 1:12 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 511
> > <https://reviews.apache.org/r/46158/diff/2/?file=1347650#file1347650line511>
> >
> >     Can you please clarify why we need the `resources` field in the `Info` class?
This is the only place I see we assign value to `Info::resources`, but it seems we never use
this field? Basically, I do not think we should have such field in `Info` class.

I think a complete container info structure for cgroup should contain the resources allocated,
so I add this before. Could remove it here.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46158/#review137677
-----------------------------------------------------------


On June 19, 2016, 3:34 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46158/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 3:34 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, Kevin Klues,
and Qian Zhang.
> 
> 
> Bugs: MESOS-5041
>     https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Completed implementation of the cgroups unified isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46158/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message