mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deshna Jain <deshna...@gmail.com>
Subject Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.
Date Sat, 18 Jun 2016 07:58:43 GMT


> On June 13, 2016, 7:41 a.m., Neil Conway wrote:
> > src/tests/scheduler_http_api_tests.cpp, line 974
> > <https://reviews.apache.org/r/48614/diff/1/?file=1416557#file1416557line974>
> >
> >     Why are we fetching the stream ID?
> 
> Vinod Kone wrote:
>     looks like you forgot to set the stream ID header when sending the acknowledge call.
if you don't set it the BadRequest response might be due to the missing stream id and not
malformed uuid. after you fix this, make sure you set an expectation on the response body
and not just response status code.

@Neil - The Scheduler API needs a valid stream id header for subsequent non subscribe calls.
We need this for the second acknowledge call.
@Vinod - Thanks for the pointing it out. I have added the check for response body in addition
to setting stream Id header.


- Deshna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48614/#review137239
-----------------------------------------------------------


On June 18, 2016, 7:58 a.m., Deshna Jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48614/
> -----------------------------------------------------------
> 
> (Updated June 18, 2016, 7:58 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5224
>     https://issues.apache.org/jira/browse/MESOS-5224
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds logic to the master/agent validation helpers
> to see if the status update acknowledgments have a valid UUID
> set conforming to one of the supported versions.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 7b9c2281b2ab1295211f0dd385cd77947fbd63be 
>   src/slave/validation.cpp 189d10caf4517a1aff62b523d8eb99d9d1ca4b6a 
>   src/tests/scheduler_http_api_tests.cpp c12205f90e4f2da2c6ad7a0ea75777601eb0ef13 
> 
> Diff: https://reviews.apache.org/r/48614/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Deshna Jain
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message