mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48879: Added logic for subscribing to task added/updated events.
Date Sat, 18 Jun 2016 03:58:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48879/#review138376
-----------------------------------------------------------




src/master/master.hpp 
<https://reviews.apache.org/r/48879/#comment203554>

    hmm. should've done this move in its own review or previous review.



src/master/master.hpp (line 369)
<https://reviews.apache.org/r/48879/#comment203550>

    lets not have a default type for Event. instead update framework->send() as discussed.



src/master/master.hpp (line 914)
<https://reviews.apache.org/r/48879/#comment203551>

    s/notify/send/ to be consisent with framework->send()



src/master/master.hpp (line 1597)
<https://reviews.apache.org/r/48879/#comment203558>

    I think you can put this in a `Subscribers` struct like we did with `Slaves`. Then the
`notify`/`send` could be inside this struct. Then we we will have `framework->send()` and
`subscribers->send()` which has a nice symmetry?



src/master/master.cpp (line 6836)
<https://reviews.apache.org/r/48879/#comment203552>

    s/Push/Send/
    s/its state/to a new state/



src/master/master.cpp (line 6853)
<https://reviews.apache.org/r/48879/#comment203553>

    no comment here?



src/master/master.cpp (line 7487)
<https://reviews.apache.org/r/48879/#comment203555>

    i'm guessing this is the only new part in this function?



src/master/master.cpp (lines 7511 - 7512)
<https://reviews.apache.org/r/48879/#comment203556>

    LOG(WARNING) << "Unknown subscribed " << id << " disconnected";



src/master/master.cpp (line 7516)
<https://reviews.apache.org/r/48879/#comment203557>

    why do you need this? isn't this method called when the http connection is closed?


- Vinod Kone


On June 17, 2016, 8:52 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48879/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 8:52 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Zhitao Li.
> 
> 
> Bugs: MESOS-5609
>     https://issues.apache.org/jira/browse/MESOS-5609
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change sets the initial scaffolding in place allowing
> a client to subscribe to events via the '/api/vX' endpoint.
> Currently, only two events are supported i.e. `TASK_ADDED`/
> `TASK_UPDATED`.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d 
>   src/master/master.hpp 0db18ad5fc5ba6f762c3ac0c2bc14c73fb243738 
>   src/master/master.cpp 1971e9bf3875ceb117130b84533dc37873ca60df 
> 
> Diff: https://reviews.apache.org/r/48879/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message