mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48841: Add Agent protobuf message.
Date Fri, 17 Jun 2016 23:33:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48841/#review138289
-----------------------------------------------------------




include/mesos/mesos.proto (line 2018)
<https://reviews.apache.org/r/48841/#comment203520>

    s/for operator API endpoints/



include/mesos/mesos.proto (line 2022)
<https://reviews.apache.org/r/48841/#comment203468>

    lets make this optional.



include/mesos/mesos.proto (line 2043)
<https://reviews.apache.org/r/48841/#comment203516>

    `Resource` message already contains role field. Not sure why we need a new `Reservation`
message?



include/mesos/v1/mesos.proto (line 1972)
<https://reviews.apache.org/r/48841/#comment203467>

    lets make this optional.



include/mesos/v1/mesos.proto (line 1979)
<https://reviews.apache.org/r/48841/#comment203524>

    s/resources/total_resources/



include/mesos/v1/mesos.proto (lines 1979 - 1981)
<https://reviews.apache.org/r/48841/#comment203525>

    can you add some comments on what each of these resources represents.



include/mesos/v1/mesos.proto (lines 1982 - 1983)
<https://reviews.apache.org/r/48841/#comment203523>

    don't think we need these because they are included in `resources`.



include/mesos/v1/mesos.proto (lines 1989 - 1994)
<https://reviews.apache.org/r/48841/#comment203526>

    kill this.


- Vinod Kone


On June 17, 2016, 6:37 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48841/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 6:37 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5491
>     https://issues.apache.org/jira/browse/mesos-5491
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch added Agent protobuf message to:
> 1. v1 message: v1/mesos.proto & v1/master/master.proto
> 2. unversioned message: mesos.proto & master/master.proto
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 3b85b8130f1a292f3574214fcf7761c891f57f22 
>   include/mesos/mesos.proto d3cfdd0a583bbd0f5ec11c87ea29e649a97450c5 
>   include/mesos/v1/master/master.proto 5a6bbeb0f9b57d03803e366df32e04e9598e00ed 
>   include/mesos/v1/mesos.proto dca0c2c8a468345cb18b4ced889fc3db0324ca1d 
> 
> Diff: https://reviews.apache.org/r/48841/diff/
> 
> 
> Testing
> -------
> 
> make 
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message