mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 48841: Add Agent protobuf message.
Date Fri, 17 Jun 2016 17:56:47 GMT


> On June 17, 2016, 6:47 a.m., haosdent huang wrote:
> > include/mesos/mesos.proto, line 2034
> > <https://reviews.apache.org/r/48841/diff/1/?file=1422091#file1422091line2034>
> >
> >     Do we need
> >     ```
> >     reserved_resources_full
> >     used_resources_full 
> >     offered_resources_full
> >     ```
> >     which contains persistent volumes?
> 
> zhou xing wrote:
>     haosdent, I'm not very clear that if the fields like "reserved_resources" or "used_resoruces"
can cover the xx_full fields?

Oh, I got you idea here, you mean `xxx_resources` here have already contains persistent volumes.
@neilc introduce `xxx_resources_full` in https://reviews.apache.org/r/44047/ because of don't
want to break the old `xxx_resources` fields structure. But this should not be a issue
for the new operator API.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48841/#review138173
-----------------------------------------------------------


On June 17, 2016, 6:37 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48841/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 6:37 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: mesos-5491
>     https://issues.apache.org/jira/browse/mesos-5491
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch added Agent protobuf message to:
> 1. v1 message: v1/mesos.proto & v1/master/master.proto
> 2. unversioned message: mesos.proto & master/master.proto
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 3b85b8130f1a292f3574214fcf7761c891f57f22 
>   include/mesos/mesos.proto d3cfdd0a583bbd0f5ec11c87ea29e649a97450c5 
>   include/mesos/v1/master/master.proto 5a6bbeb0f9b57d03803e366df32e04e9598e00ed 
>   include/mesos/v1/mesos.proto dca0c2c8a468345cb18b4ced889fc3db0324ca1d 
> 
> Diff: https://reviews.apache.org/r/48841/diff/
> 
> 
> Testing
> -------
> 
> make 
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message