mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.
Date Fri, 17 Jun 2016 17:39:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48580/#review138260
-----------------------------------------------------------


Ship it!





src/tests/api_tests.cpp (line 459)
<https://reviews.apache.org/r/48580/#comment203437>

    s/associate/associated/
    
    i'll fix this while committing.



src/tests/api_tests.cpp (line 479)
<https://reviews.apache.org/r/48580/#comment203439>

    s/an unscheduled machine/unscheduled machines/
    
    i'll fix this while committing.



src/tests/api_tests.cpp (line 531)
<https://reviews.apache.org/r/48580/#comment203438>

    extra "//".
    
    i'll fix this while committing.


- Vinod Kone


On June 17, 2016, 1:28 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48580/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 1:28 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5507
>     https://issues.apache.org/jira/browse/MESOS-5507
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test case `MasterAPITest.StartAndStopMaintenance`.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 
> 
> Diff: https://reviews.apache.org/r/48580/diff/
> 
> 
> Testing
> -------
> 
> Test by
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter="*APITest*"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message