mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 48861: Added preview logo for facebook.
Date Fri, 17 Jun 2016 17:24:38 GMT


> On June 17, 2016, 5:12 p.m., Tomasz Janiszewski wrote:
> > site/source/layouts/basic.erb, line 7
> > <https://reviews.apache.org/r/48861/diff/1/?file=1422500#file1422500line7>
> >
> >     How about adding other tags `og:site_name` and `og:title`. By default type is
set to website is that correct for docs and blog posts?

Haha, actually facebook standard require `og:type`, `og:url`, `og:title`, `og:description`,
`fb:app_id` as well.
However, I found the facebook preview works if just set `og:image` and I try to avoid bring
too much unnecessary `meta` tags which only work for facebook.
Do you think this make sense? I could continue to add `og:site_name` and `og:title` if you
think they are necessary. Just need add two lines. :-)


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48861/#review138246
-----------------------------------------------------------


On June 17, 2016, 4:55 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48861/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 4:55 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Tomasz Janiszewski, Jie Yu, and Vinod
Kone.
> 
> 
> Bugs: MESOS-5617
>     https://issues.apache.org/jira/browse/MESOS-5617
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added preview logo for facebook.
> 
> 
> Diffs
> -----
> 
>   site/source/assets/img/mesos_logo_fb_preview.png PRE-CREATION 
>   site/source/layouts/basic.erb d654cab802dd60bc70bafac124d411048800fb7a 
> 
> Diff: https://reviews.apache.org/r/48861/diff/
> 
> 
> Testing
> -------
> 
> Example:
> ![facebook_post](https://issues.apache.org/jira/secure/attachment/12811410/facebook_post.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message