mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 48849: Removed capturing this in sandbox authorization.
Date Fri, 17 Jun 2016 15:24:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48849/#review138236
-----------------------------------------------------------



Patch looks great!

Reviews applied: [48849]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On June 17, 2016, 2:22 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48849/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 2:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Till Toenshoff.
> 
> 
> Bugs: MESOS-5629
>     https://issues.apache.org/jira/browse/MESOS-5629
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously we captured `this` in the lambda. As we store the lamda in
> the FilesProcess accessing `this` can lead to segmentation faults.
> The problem here is that the `Framework` might go out of scope and
> hence `this` might be a dangling pointer.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 0af04d6fe53f92e03905fb7b3bec72b09d5e8e57 
> 
> Diff: https://reviews.apache.org/r/48849/diff/
> 
> 
> Testing
> -------
> 
> make check + checked scenario which previously led to segfault.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message