mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 48849: Removed capturing this in sandbox authorization.
Date Fri, 17 Jun 2016 14:22:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48849/
-----------------------------------------------------------

(Updated June 17, 2016, 2:22 p.m.)


Review request for mesos, Alexander Rojas and Till Toenshoff.


Bugs: MESOS-5629
    https://issues.apache.org/jira/browse/MESOS-5629


Repository: mesos


Description (updated)
-------

Previously we captured `this` in the lambda. As we store the lamda in
the FilesProcess accessing `this` can lead to segmentation faults.
The problem here is that the `Framework` might go out of scope and
hence `this` might be a dangling pointer.


Diffs (updated)
-----

  src/slave/slave.cpp 0af04d6fe53f92e03905fb7b3bec72b09d5e8e57 

Diff: https://reviews.apache.org/r/48849/diff/


Testing (updated)
-------

make check + checked scenario which previously led to segfault.


Thanks,

Joerg Schad


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message