mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 48832: Changed build to always enable Nvidia GPU support for Linux.
Date Fri, 17 Jun 2016 08:37:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48832/#review138184
-----------------------------------------------------------



Patch looks great!

Reviews applied: [48832]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On June 17, 2016, 6:29 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48832/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 6:29 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5630
>     https://issues.apache.org/jira/browse/MESOS-5630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, we supported a configure flag for
> `--enable-nvidia-gpu-support` to explicitly enable Nvidia GPU support
> when building Mesos on Linux. This commit removes this flag and
> enables this support for all builds on Linux.
> 
> As part of this change, libelf now becomes a build dependence on Linux
> for all build configurations. We update the docs and the docker build
> scripts to accomodate this.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 0df0d4ccd76379ede6492e595999711e5462f79b 
>   configure.ac 101be52a304b969c55619dc7891c1e5ad008eef1 
>   docs/getting-started.md 8c72e5ec1263adb8792c8c49ede50bbf649e1ef3 
>   src/Makefile.am 7a578c642309560d53466249b2ccca1df5f070b1 
>   src/slave/containerizer/containerizer.cpp 37ce1baed96a09f7b5542e61e06540434c860af0

>   src/slave/containerizer/mesos/containerizer.cpp 875b024a60719a3e99b18592aef104cad6279c90

>   src/slave/flags.hpp 52ce5034fa2d0db7d1db43715752f71cdb770ef8 
>   src/slave/flags.cpp ce2aa336f779ee6746d5f62136251af2c7191f9d 
>   support/docker_build.sh 82ec9e794c959eab4649d30d678b94a71e727edf 
> 
> Diff: https://reviews.apache.org/r/48832/diff/
> 
> 
> Testing
> -------
> 
> Build / run unit tests in three build environments:
> ```
> 1) CentOS 7 on GPU capable machine
> 2) CentOS 7 on NON-GPU capable machine
> 3) OSX
> 
> $ rm -rf build; ./bootstrap; mkdir build; cd build; ../configure; make -j check; sudo
GTEST_FILTER="*NVIDIA*" src/mesos-tests
> ```
> Test support/build_docker.sh (to make sure we won't crash Apache's CI):
> ```
> $ ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1' CONFIGURATION="--enable-libevent --enable-ssl"
COMPILER=gcc BUILDTOOL=autotools OS=centos:7 support/docker_build.sh
> 
> $ ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1' CONFIGURATION="--enable-libevent --enable-ssl"
COMPILER=gcc BUILDTOOL=autotools OS=ubuntu:14.04 support/docker_build.sh
> ```
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message