mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.
Date Fri, 17 Jun 2016 08:32:21 GMT


> On June 17, 2016, 6:29 a.m., haosdent huang wrote:
> > src/master/http.cpp, line 2485
> > <https://reviews.apache.org/r/48094/diff/3/?file=1421260#file1421260line2485>
> >
> >     Hi, @a10gupta Could not got the idea that why you rename to `_roles` here. Seems
you have never reuse this function?

yeah...it is fixed now and updated after your patch.


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48094/#review138169
-----------------------------------------------------------


On June 17, 2016, 8:30 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48094/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 8:30 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5494
>     https://issues.apache.org/jira/browse/MESOS-5494
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented GET_ROLES Call in v1 master API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 3b85b8130f1a292f3574214fcf7761c891f57f22 
>   include/mesos/mesos.proto d3cfdd0a583bbd0f5ec11c87ea29e649a97450c5 
>   include/mesos/v1/master/master.proto 5a6bbeb0f9b57d03803e366df32e04e9598e00ed 
>   include/mesos/v1/mesos.proto dca0c2c8a468345cb18b4ced889fc3db0324ca1d 
>   src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d 
>   src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
>   src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 
> 
> Diff: https://reviews.apache.org/r/48094/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> 
> sudo GTEST_FILTER="*MasterAPITest.*" make -j2 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message