mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 48838: Added missing `stout/elf.hpp` file to `nobase_include_HEADERS`.
Date Fri, 17 Jun 2016 05:44:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48838/#review138161
-----------------------------------------------------------


Ship it!




- Kapil Arya


On June 17, 2016, 1:44 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48838/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 1:44 a.m.)
> 
> 
> Review request for mesos and Kapil Arya.
> 
> 
> Bugs: 5400
>     https://issues.apache.org/jira/browse/5400
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Without this, files that #included `stout/elf.hpp` would fail with a
> `make distcheck` because this file was not being installed properly
> from a `make install`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/Makefile.am 7f31582c176e653873402bd3f19b0c0195503d45 
> 
> Diff: https://reviews.apache.org/r/48838/diff/
> 
> 
> Testing
> -------
> 
> $ make install (in 3rdparty)
> Verified that it installed the elf.hpp file
> 
> $ ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1' CONFIGURATION="--enable-libevent --enable-ssl"
COMPILER=gcc BUILDTOOL=autotools OS=centos:7 support/docker_build.sh
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message