mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 48836: Fixed variable shadowing in `launchTaskPosix`.
Date Fri, 17 Jun 2016 04:49:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48836/#review138156
-----------------------------------------------------------



Patch looks great!

Reviews applied: [48836]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On June 17, 2016, 3:34 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48836/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 3:34 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed variable shadowing in `launchTaskPosix`.
> 
> 
> Diffs
> -----
> 
>   src/launcher/posix/executor.cpp 76c7a267ec9fdaefe9b34a5f0cd55b893aafd280 
> 
> Diff: https://reviews.apache.org/r/48836/diff/
> 
> 
> Testing
> -------
> 
> ```
> pid_t launchTaskPosix(
>     const mesos::v1::TaskInfo& task,
>     const mesos::v1::CommandInfo& command,
>     const Option<string>& user, <--- shadown with `Result<string>
user = os::user();` below.
>     char** argv,
>     Option<char**>& override,
>     Option<string>& rootfs,
>     Option<string>& sandboxDirectory,
>     Option<string>& workingDirectory)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message