mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 48836: Fixed variable shadowing in `launchTaskPosix`.
Date Fri, 17 Jun 2016 03:34:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48836/
-----------------------------------------------------------

(Updated June 17, 2016, 3:34 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Jie Yu, and Vinod Kone.


Repository: mesos


Description
-------

Fixed variable shadowing in `launchTaskPosix`.


Diffs
-----

  src/launcher/posix/executor.cpp 76c7a267ec9fdaefe9b34a5f0cd55b893aafd280 

Diff: https://reviews.apache.org/r/48836/diff/


Testing (updated)
-------

```
pid_t launchTaskPosix(
    const mesos::v1::TaskInfo& task,
    const mesos::v1::CommandInfo& command,
    const Option<string>& user, <--- shadown with `Result<string> user
= os::user();` below.
    char** argv,
    Option<char**>& override,
    Option<string>& rootfs,
    Option<string>& sandboxDirectory,
    Option<string>& workingDirectory)
```


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message