mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48401: Change GetTask.limit type to int32 with default value 100.
Date Fri, 17 Jun 2016 00:35:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48401/#review138136
-----------------------------------------------------------




include/mesos/v1/master.proto (line 111)
<https://reviews.apache.org/r/48401/#comment203351>

    can you also update the unversioned master.proto (that we recently added) with these changes?


- Vinod Kone


On June 9, 2016, 12:01 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48401/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 12:01 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5493
>     https://issues.apache.org/jira/browse/MESOS-5493
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This protobuf message should be int32 instead of string.
> Default value is set to TASK_LIMIT (100).
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 
> 
> Diff: https://reviews.apache.org/r/48401/diff/
> 
> 
> Testing
> -------
> 
> make check on ubuntu 14.04
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message