mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.
Date Fri, 17 Jun 2016 00:18:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/#review138131
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On June 16, 2016, 10:48 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48039/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 10:48 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod Kone, and
Zhitao Li.
> 
> 
> Bugs: MESOS-5628
>     https://issues.apache.org/jira/browse/MESOS-5628
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As described in MESOS-5628, this patch makes `QuotaHandler` only
> send one authorization request per action.
> 
> During the deprecation cycle of `ACL::SetQuota` and `ACL::RemoveQuota`,
> the `LocalAuthorizer` for example still needs to know whether the action
> is a set or remove. We remedy this situation by encoding type (set or
> remove) by setting the `value` field in the `Object` with the string
> `"SetQuota"` or `"RemoveQuota"`. With this approach, we can simply stop
> setting the `value` field at the end of the deprecation cycle as opposed
> to changing the public API.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
>   src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 
> 
> Diff: https://reviews.apache.org/r/48039/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message