mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 48825: Added documentation about replicated log metrics.
Date Thu, 16 Jun 2016 23:35:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48825/#review138122
-----------------------------------------------------------


Fix it, then Ship it!





docs/monitoring.md (line 273)
<https://reviews.apache.org/r/48825/#comment203338>

    Might want to note that the in-memory version (i.e. for testing via `--registry=in_memory`)
will not have this metric.  
    
    Probably not a general use case though :)



docs/monitoring.md (line 275)
<https://reviews.apache.org/r/48825/#comment203340>

    Suggestion:
    
    s/recovered/caught up with the other masters in the cluster.  A cluster is operational
as long as a quorum of "recovered" masters is available in the cluster./
    
    Also note that a "recovered" registrar will never go from 1 -> 0 without out-right
aborting/crashing.


- Joseph Wu


On June 16, 2016, 4:22 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48825/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 4:22 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation about replicated log metrics.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 3cfdaf5de149c5a1a7b3d64ba2870887a092ffc6 
> 
> Diff: https://reviews.apache.org/r/48825/diff/
> 
> 
> Testing
> -------
> 
> Preview:
> https://github.com/jieyu/mesos/blob/metrics_replicated_log/docs/monitoring.md#registrar
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message