mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 48366: Added auto-discovery of GPUs for Nvidia GPU support.
Date Thu, 16 Jun 2016 23:25:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48366/#review138106
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/containerizer.cpp (lines 114 - 121)
<https://reviews.apache.org/r/48366/#comment203318>

    We should add context to these error messages.



src/slave/containerizer/containerizer.cpp (lines 125 - 126)
<https://reviews.apache.org/r/48366/#comment203319>

    No backticks in the output that we print out to the user (error messages, log messages,
etc).



src/slave/containerizer/containerizer.cpp (line 140)
<https://reviews.apache.org/r/48366/#comment203320>

    s/unsigned/non-negative/?


- Benjamin Mahler


On June 11, 2016, 3:07 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48366/
> -----------------------------------------------------------
> 
> (Updated June 11, 2016, 3:07 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5257
>     https://issues.apache.org/jira/browse/MESOS-5257
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit also includes updates to the tests that would start
> failing once GPU autodiscovery was turned on. Since GPUs are now a
> first class resource, we have to explicilty list them in resource
> vectors that attempt to set resources for the whole machine and then
> verify that they get the same vector back in an offer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.cpp faa0c789dda8a6f36fdb6217b0bae270b6b8f2e2

>   src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp d7557a0c338e8c0e51461b2326600c03f89c2e8b

>   src/tests/master_allocator_tests.cpp 34e3add78d0dec8fb55d7b35710694bea3c58d6f 
>   src/tests/master_quota_tests.cpp 62aaafe7b11a7df1ca7bc1f2f29af4cb626fc35d 
>   src/tests/master_tests.cpp 0d64e353f0682017953b524a5f5246d76f52fa2e 
>   src/tests/mesos.hpp e9361a65eb31cced99e9ed32fd18a65d1bda26e3 
>   src/tests/persistent_volume_endpoints_tests.cpp 70b7626c8e87d1de59b13f9fd88fe9abb5f6b6a5

>   src/tests/slave_tests.cpp 7ba03e8c06b8aaac1e57124c257660acd8c1d78a 
> 
> Diff: https://reviews.apache.org/r/48366/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message