mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.
Date Thu, 16 Jun 2016 22:04:55 GMT


> On May 30, 2016, 1:22 p.m., Till Toenshoff wrote:
> > src/master/quota_handler.cpp, lines 575-580
> > <https://reviews.apache.org/r/48039/diff/1/?file=1400970#file1400970line575>
> >
> >     Is there a JIRA around introducing LocalAuthorizer specific deprecation cycles
- I would like to understand why we are not pushing this request out to any authorizer (module).
> 
> Alexander Rukletsov wrote:
>     There is no JIRA afaik. In short, the reason why local authorizer is "special" is
because the authorizer interface has been refactored in 0.29 and hence we can simply avoid
introducing enum values corresponding to the quota authz actions being deprecated in 0.29.
However, we still must support related ACLs, which are relevant only to local authorizer.
In one sentence: any authorizer (module) is revamped in 0.29 hence no deprecation is needed,
while LocalAuthorizer should go through deprecation.

@Till: We've removed this check and decided to always set the `value` field. Note that this
is still an internal hack, thus we do not claim to set the `value` field at the public API
level.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/#review135510
-----------------------------------------------------------


On June 16, 2016, 9:45 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48039/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 9:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod Kone, and
Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `QuotaHandler` to only one authorization request per action.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
>   src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 
> 
> Diff: https://reviews.apache.org/r/48039/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message